How far are you looking at going?
Depending on the weather and where the sun is, Turnhouse can be quite good
down this lane, but watch yourself turning into it - I have to take it at an angle or my car will bottom out. I've not been down there for a while, but if the pothole in the middle of the entrance is there, go round the side of it, don't try and drive through it.
A couple of places around Craigentinny that I've used before are
here and
here.
The first one can be ok for photos, but last time I went there (a year or two back) the bushes were starting to grow and block the view, making it tricky to get anything decent. The second I've only been to a couple of times, and was better than I was expecting, but not amazing.
Since you've been to Kingsknowe, try the foot crossings further along the line.
This one is better for video rather than photos, but it is possible to get half decent photos.
I prefer
this one, personally, as it has long straights either side.
By car, for the one near Riccarton, it's a little easier to approach from the North side, and it's easier to park (though don't block the driveway - I always tuck my car up against the fence opposite), and the one past Currie is much easier to get to from the Southern side.
If you've got time to kill and fuel to spare, occasionally I'd just try and follow one of the lines as close as I could in the car and investigate anything that looked like it could work.