I'm only 26 but from looking at old classic bus magazines, I think it was the Leyland 510 engine that might have been the main course of questioning whether the Leyland National was a success or failure.
The repowering of most Nationals with Leyland TL11, Leyland 680, Cummins L10 (I think) and DAF engines were meant to improve the reliability of Nationals. Whether this was the case I'm not sure.
Most of those re-engines happened quite late on though. The National 2 never came with the 510 - but putting new / different engines in Nationals didn't really take off until the late 80s, by which time most were at least 10 years old. The 510 was clearly a 'marmite' engine - some operators got it to work and reliably - albeit noisily - for very many years. Others soon developed an intense dislike of it. I think you have to view the repowering more as extending the life of a National - in the same way the Greenway did - as a way of delaying the purchase of new vehicles.